Skip to content

Allow phases to give restrictions on pipeline position. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2014

Conversation

DarkDimius
Copy link
Contributor

Phases can now specify which phases should it precede and follow.
Tree transforms can additionally specify which TreeTransforms
should have finished their processing of compilation units entirely.

@DarkDimius
Copy link
Contributor Author

@odersky @gzm0 please review

@gzm0
Copy link
Contributor

gzm0 commented Apr 3, 2014

LGTM

@DarkDimius
Copy link
Contributor Author

When would you need to demand ensureFinished?

in order to start, Lazy vals needs LazyValsCreateCompanionObjects to finish it's work.
I propose having 2 methods:

def runsAfter: List[Phase]
def differentGroupsWith: List[Phase]

@odersky
Copy link
Contributor

odersky commented Apr 7, 2014

How about:

def runsAfter: List[Phase]
def runsAfterGroupOf: List[Phase]

@DarkDimius
Copy link
Contributor Author

Can you explain what

  def runsAfterGroupOf: List[Phase]

should express? List of phases, groups of which your phase should follow?

@odersky
Copy link
Contributor

odersky commented Apr 8, 2014

It means: The current phase runs after the groups of the phases given in the list. Maybe

 runsAfterGroupsOf

is clearer? I think I like that better.

Phases can now specify which phases should it follow.
Tree transforms can additionally specify which TreeTransforms
should have finished their processing of compilation units entirely.
DarkDimius added a commit that referenced this pull request Apr 11, 2014
Allow phases to give restrictions on pipeline position.
@DarkDimius DarkDimius merged commit ee214a5 into scala:master Apr 11, 2014
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "Handle old given syntax where identifier and type are seperated by new line" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants