Stop using the CompilerClassLoader in sbt-bridge #10960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the hazardous
CompilerClassLoader
.As a counterpart it makes the scala compiler bridge incompatible with sbt 1.3.x and Mill older than
0.9.3-21-002361
.EDIT:
My initial goal was to get rid of the
CompilerClassLoader
but it is probably safer to transition smoothly. So this PR only tries to not use theCompilerClassLoader
. When the class loader appears to be badly configured, it prints a warning and falls back to the old technique:I tested on:
1.3.13
with sbt-dotty1.4.6
:0.9.3
1.4.6
The warning goes away with sbt
1.4.x
(sbt-dotty1.5.1
) and Mill0.9.4
.[test_sbt]