Skip to content

Don't generate case class method if it clashes with inherited concret… #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2020
Merged

Don't generate case class method if it clashes with inherited concret… #10926

merged 2 commits into from
Dec 30, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 27, 2020

…e member

Fixes #10866

@odersky
Copy link
Contributor Author

odersky commented Dec 27, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 8 job(s) in queue, 1 running.

@odersky odersky requested a review from bishabosha December 27, 2020 17:57
@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10926/ to see the changes.

Benchmarks is based on merging with master (8fab91c)

bishabosha
bishabosha approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performance hit doesn't look so bad

@odersky
Copy link
Contributor Author

odersky commented Dec 28, 2020

Test performance please

(just to be sure)

@odersky
Copy link
Contributor Author

odersky commented Dec 28, 2020 •
edited by liufengyun
Loading

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@odersky
Don't try to invalidate creator proxies
5204f13 
We generate them in the only if there are no clashes to start with.
So, no need to check that again.
@odersky
Copy link
Contributor Author

odersky commented Dec 29, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@odersky
Copy link
Contributor Author

odersky commented Dec 29, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 2 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10926/ to see the changes.

Benchmarks is based on merging with master (d932af9)

@bishabosha
Copy link
Member

the spike looks consistent but it is not so big looking at the trend over time

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/10926/ to see the changes.

Benchmarks is based on merging with master (d932af9)

@odersky odersky merged commit 0a8bb4b into scala:master Dec 30, 2020
@odersky odersky deleted the fix-#10866 branch December 30, 2020 16:39
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Case class creates an unapply method even if one is inherited in the companion object
4 participants
@odersky @dottybot @bishabosha @Kordyjan