FullParametrization: allow to have $this of ThisType. #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sjrd please review |
| * @param abstractOverClass if true, include the type parameters of the class in the method's list of type parameters. | ||
| * @param liftThisType if true, require created $this to be $this: (Foo[A] & Foo,this). |
There was a problem hiding this comment.
Why not have the type of $this simply be Foo.this when liftThisType is true?
|
As far as I understand, LGTM. |
|
@sjrd, neg tests fail as normal. Actual test failure is in ./scala-scala/src/library/scala/collection/immutable/TrieIterator.scala. I'm having a look at it. |
TailRec methods remain members of enclosing class, it means that they can refer to methods that require this.type. It means that tailrec, unlike value classes is not allowed to widen type of $this to it's full self type. Fixes scala#1089
If the method that recurses over a different type arguments, if this method is specialised, it would lead to method not being tail-rec anymore. Eg: def foo[@specialized A, @specialized B]: Unit = foo[B, A]
This is a simpler fix than the previous one. Local methods, cannot change `this` and do not need to go through FullParameterization.
|
rebased over master. |
|
LGTM. I'll rebase the other one to see if it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TailRec methods remain members of enclosing class,
it means that they can refer to methods that require this.type.
It means that tailrec, unlike value classes is not allowed to widen
type of $this to it's full self type.
Fixes #1089