Parsing indentation cleanup #10861
Merged
Parsing indentation cleanup #10861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
reviewed
Dec 23, 2020
| @@ -3708,8 +3708,8 @@ object Parsers { | |||
|
|
|||
| /** with Template, with EOL <indent> interpreted */ | |||
There was a problem hiding this comment.
should this comment be updated? Is this comment a pseudo grammar? Just from the comment it is not clear which "with" is a keyword and whether "," is a token or an informal alternative.
| @@ -80,11 +84,15 @@ object Test: | |||
|
|
|||
| class Test2: | |||
| self => | |||
| def foo = 1 | |||
| def foo(x: Int) = | |||
| if x < 0 then throw | |||
There was a problem hiding this comment.
Do we really want to allow this? I somehow parse this as:
if x < 0 then { throw();
val ex = ...
}There was a problem hiding this comment.
For consistency I think it is better to allow it. The given expression abuses indentation rules for sure. It should be formatted like this:
if x < 0 then
throw
val ex = ...
ex
odersky
force-pushed
the
with-templates
branch
from
0da59cd to
a885152
Compare
Change parsing algorithm so that we do not need a separate WITHEOL token. The grammar remains unaffected.
odersky
force-pushed
the
with-templates
branch
from
c7b816c to
625f754
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate WITHEOL token: Change parsing algorithm so that we do not need a separate WITHEOL token. The grammar remains unaffected.
Make indentation significant after
throwand?=>