Skip to content

Try to fix paths in TastyInspector #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Try to fix paths in TastyInspector #10777

wants to merge 1 commit into from

Conversation

abgruszecki
Copy link
Contributor

Right now postProcess is way less useful than it should be, since the path-dependent types interfere with gathering Trees. This PR is to try and see if we can still fix that.

@abgruszecki
Copy link
Contributor Author

@nicolasstucki I discovered an issue w/ postProcess when working on the doctool. The idea behind postProcess was that it was supposed to allow encoding arbitrary folds on all compilation units. I tried to use it like that and could not, I needed to hack into the compiler as you can see here: https://github.com/lampepfl/dotty/pull/10659/files#diff-b884802b09203bfdfec2d7502af95c5da059aa94032748579a60b5cbeed858b1R39-R48 . This PR tries to fix that by presenting an alternative interface where there is only one path prefix for Tree. We may want to adjust the interface (this PR is just a PoC), the question is: is it sound to only have one Quotes instance in a TastyInspector run, and do we want to actually expose that?

@nicolasstucki nicolasstucki mentioned this pull request Dec 14, 2020
Merged
@nicolasstucki
Copy link
Contributor

Replaced with #10792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abgruszecki @nicolasstucki