Add Printer to reflect Constant.show #10755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Dec 11, 2020
|
|
||
| lazy val ConstantStructure: Printer[Constant] = new Printer[Constant]: | ||
| def show(const: Constant): String = | ||
| Extractors.showConstant(using QuotesImpl.this)(const) |
There was a problem hiding this comment.
Is there usage for ConstantStructure? If ConstantCode is the only printer, maybe change toString and/or show method is enough for practical usage.
There was a problem hiding this comment.
ConstantStructure is mainly used for debugging.
We do not have access to the Context in the to toString which we need to handle the ClassOf case. In general, we tell users that the toString is unreliable and that they should use show, this should not be an exception or it may lead to confusion.
nicolasstucki
force-pushed
the
add-printer-to-constant-show
branch
from
5ab7689 to
71ae463
Compare
We can either print the structure with the pattern or the code like representation of the value.
nicolasstucki
force-pushed
the
add-printer-to-constant-show
branch
from
71ae463 to
6f4b958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can either print the structure with the pattern or the code like representation of the value.