Improve soft modifiers docs #10748
Merged
Improve soft modifiers docs #10748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Dec 11, 2020
docs/docs/reference/soft-modifier.md
Outdated
| @@ -9,7 +9,6 @@ TODO this is most likely outdated should at least contain `extension` in additio | |||
| Worth maintaining? or maybe better refer to internal/syntax.md ? | |||
| --> | |||
|
|
|||
| It is treated as a potential modifier of a definition, if it is followed by a hard modifier or a keyword combination starting a definition (`def`, `val`, `var`, `type`, `class`, `case class`, `trait`, `object`, `case object`, `enum`). Between the two words there may be a sequence of newline tokens and soft modifiers. | |||
| It is treated as a potential modifier of a definition if it is followed by a hard modifier or a keyword combination starting a definition (`def`, `val`, `var`, `type`, `class`, `trait`, `object`, `enum`, `given`). Between the two words there may be a sequence of newline tokens and soft modifiers. In addition, `inline` is a keyword for `inline if`, `inline ... match`, and inline parameters. | |||
There was a problem hiding this comment.
Are case object and case class removed by accident?
There was a problem hiding this comment.
I removed them on purpose. case class definitions are class definitions. Having both seemed to be redundant. The same applies to object and case object.
There was a problem hiding this comment.
The file Tokens.scala contains the definitions defIntroTokens and templateIntroTokens. It might be a little better to align with the definitions there.
camilaagw
force-pushed
the
improve-docs-soft-modifiers
branch
from
72d1bca to
445db39
Compare
camilaagw
force-pushed
the
improve-docs-soft-modifiers
branch
from
445db39 to
9c84189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.