Remove scalaShadowing from the compiler
#10708
Conversation
nicolasstucki
force-pushed
the
remove-scala-shadowing
branch
from
1a4e9e3 to
3a02ac2
Compare
| // if the scala.compiletime package is missing, the dotty library must be missing | ||
| (prefix.symbol.owner == defn.RootClass && prefix.name == nme.scala && selector == nme.compiletime) |
There was a problem hiding this comment.
This isn't really useful, the point of checking for scalaShadowing before is that we explicitly force it when starting the compiler, but the same isn't true for scala.compiletime, so there is no reason to special-case it here.
There was a problem hiding this comment.
Should we force something in the dotty library to be able to detect if it is not on the classpath. Or should we drop the check and just fail with a random non existent symbol error?
There was a problem hiding this comment.
I would drop the check for now, we want to avoid cascade of errors when symbols are missing, but this should be achievable without special casing dotty-library
There was a problem hiding this comment.
I dropped the check
nicolasstucki
force-pushed
the
remove-scala-shadowing
branch
from
3a02ac2 to
24eb6cf
Compare
| @@ -16,7 +16,9 @@ class MissingCoreLibTests { | |||
| val reporter = Main.process(options) | |||
| assertEquals(1, reporter.errorCount) | |||
| val errorMessage = reporter.allErrors.head.message | |||
| assertTrue(errorMessage.contains("Make sure the compiler core libraries are on the classpath")) | |||
| // FIXME: We currently only detect if the scala library is missing but not the dotty library. | |||
There was a problem hiding this comment.
Will open an issue referencing this once it is merged
This is the first step towards fixing #10707