Fix scas compiler version #10631
Closed
Fix scas compiler version #10631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already override the compiler globally, it seems to be enough: |
|
It seems to have failed the tests |
|
@anatoliykmetyuk Do you know if the following is necessary for mill (all other mill projects do the same), given that there is already a global override? - baseCommand = "scas.application"
+ baseCommand = s"scas.application[$compilerVersion]" |
|
What needs to be done is this: For all mill projects. Then the baseCommand should be as you specified and will work. Mill projects get these envvars via this line. |
|
The necessary changes are now in #10632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scas compiler version