Skip to content

Enable -Ycheck-init on community projects and CI #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Enable -Ycheck-init on community projects and CI #10627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
be0898f
Remove unused file
liufengyun Nov 27, 2020
ee510e4
Refactor check and implement promotion
liufengyun Nov 27, 2020
684c370
Fix debugging code
liufengyun Nov 28, 2020
912646c
Don't produce duplicate select effect in potential expansion
liufengyun Nov 28, 2020
9acd96e
Revert #9673
liufengyun Nov 29, 2020
eae39d5
check initialization in community build
liufengyun Dec 3, 2020
b2d85d6
Use correct owner for summarizing effects in parent calls
liufengyun Dec 4, 2020
0deeed4
Fix crash: ensure class type is applied
liufengyun Dec 4, 2020
350ee11
Fix stdlib CB: don't check language patches
liufengyun Dec 4, 2020
ada5a0b
Suppress warning in shapeless
liufengyun Dec 4, 2020
4f90027
Restore tests
liufengyun Dec 4, 2020
fc339e6
Fix CI: ignore export clause
liufengyun Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion community-build/community-projects/shapeless
Open in desktop
Submodule shapeless updated 1 files
+1 −1 modules/deriving/src/main/scala/shapeless3/deriving/deriving.scala
1 change: 1 addition & 0 deletions community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ final case class SbtCommunityProject(
private val baseCommand =
"clean; set logLevel in Global := Level.Error; set updateOptions in Global ~= (_.withLatestSnapshots(false)); "
++ s"""set dependencyOverrides in ThisBuild ++= ${dependencyOverrides.mkString("Seq(", ", ", ")")}; """
++ """set scalacOptions in Global += "-Ycheck-init";"""
++ s"++$compilerVersion!; "

override val testCommand = s"$baseCommand$sbtTestCommand"
Expand Down
5 changes: 3 additions & 2 deletions compiler/src/dotty/tools/dotc/transform/init/Checker.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import ast.tpd
import dotty.tools.dotc.core._
import Contexts._
import Types._
import Symbols._

import dotty.tools.dotc.transform._
import MegaPhase._
Expand Down Expand Up @@ -45,9 +46,9 @@ class Checker extends MiniPhase {
}

// A concrete class may not be instantiated if the self type is not satisfied
if (instantiable) {
if (instantiable && cls.enclosingPackageClass != defn.StdLibPatchesPackage.moduleClass) {
implicit val state: Checking.State = Checking.State(
visited = Set.empty,
checked = Set.empty,
path = Vector.empty,
thisClass = cls,
fieldsInited = mutable.Set.empty,
Expand Down
Loading