Skip to content

Cleanup compiletime package #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

anatoliykmetyuk
Copy link
Contributor

I did not get rid of the compiletime package object itself due to an obscure error message. When I try to get rid of it and express everything in it as top-level definitions, I get the following error:

Error
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:18:0
[error] 18 |erased def erasedValue[T]: T = ???
[error]    |^
[error]    |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:52:7
[error] 52 |  error("Compiler bug: `codeOf` was not evaluated by the compiler")
[error]    |       ^
[error]    |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:70:7
[error] 70 |  error("Compiler bug: `requireConst` was not evaluated by the compiler")
[error]    |       ^
[error]    |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:78:7
[error] 78 |  error("Compiler bug: `constValueOpt` was not evaluated by the compiler")
[error]    |       ^
[error]    |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:85:7
[error] 85 |  error("Compiler bug: `constValue` was not evaluated by the compiler")
[error]    |       ^
[error]    |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:106:41
[error] 106 |      case _: (t *: ts) => constValue[t] *: constValueTuple[ts]
[error]     |                                         ^
[error]     |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:125:7
[error] 125 |  error("Compiler bug: `summonFrom` was not evaluated by the compiler")
[error]     |       ^
[error]     |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:133:55
[error] 133 |transparent inline def summonInline[T]: T = summonFrom
[error]     |
[error]     |package scala.compiletime.package does not have a member method summonFrom
[error] -- Error: /Users/kmetiuk/Projects/scala3/dotty/library/src/scala/compiletime/package.scala:147:43
[error] 147 |      case _: (t *: ts) => summonInline[t] *: summonAll[ts]
[error]     |                                           ^
[error]     |package scala.compiletime.package does not have a member method summonFrom
[error] 9 errors found

Does top-level vs package object influence the API exposed to the end-user? If not, I'd suggest not going for the compiletime package object FTTB.

@anatoliykmetyuk anatoliykmetyuk added this to the 3.0.0-M3 milestone Dec 8, 2020
@anatoliykmetyuk anatoliykmetyuk force-pushed the cleanup-compiletime branch 2 times, most recently from 2fb99fd to ec5bece Compare December 8, 2020 14:50
@anatoliykmetyuk anatoliykmetyuk merged commit 73c8849 into scala:master Dec 9, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the cleanup-compiletime branch December 9, 2020 17:30
smarter added a commit to dotty-staging/dotty that referenced this pull request Dec 12, 2020
…piletime"

This reverts commit 73c8849, reversing
changes made to efc9edb.
@Kordyjan Kordyjan modified the milestones: 3.0.0-M3, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants