Generate lazy vals in deriving #10520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid generating them with a PolyType over an ExpreType. Instead of `[T] (=> U)` we should generate `[T]U`. That's what we do for all user-defined types.
smarter
approved these changes
Nov 26, 2020
compiler/src/dotty/tools/dotc/transform/UncacheGivenAliases.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we generated only given defs in typeclass derivation which we then optimized to lazy vals in CacheAliasImplicits. We now generate the lazy vals directly, which means that CacheAliasImplicits only needs to work in one direction: dropping the caches converting lazy vals to defs. Consequently, it has been renamed to UncacheGivenAliases.