Skip to content

Trial: Postfix as #10489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Trial: Postfix as #10489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
326ba1b
Parser refactorings
odersky Nov 25, 2020
4c9002b
Refine followingIsGivenSig to not get confused by postfix `as`
odersky Nov 25, 2020
553c881
Factor out parsing that's only relevant if there is a given sig
odersky Nov 25, 2020
3ad77e3
Enable suffix as in given defs
odersky Nov 25, 2020
b3a989f
Switch tests to postfix as
odersky Nov 25, 2020
924672b
Fix followingIsGivenSig
odersky Nov 25, 2020
b9e39c5
Switch more tests to postfix as
odersky Nov 25, 2020
4901185
Update semanticdb expect files
odersky Nov 25, 2020
1cf5c4d
Refactorings: maybeParams
odersky Nov 26, 2020
5f52f0c
Convert more tests to postfix as
odersky Nov 26, 2020
b8294e6
Switch to postfix as in CB
odersky Nov 26, 2020
25bc960
Support `given => T` syntax for uncached givens
odersky Nov 26, 2020
943fc35
Update docs
odersky Nov 26, 2020
86101b1
Switch to postfix `as` for patterns
odersky Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion community-build/community-projects/PPrint
Open in desktop
Submodule PPrint updated 1 files
+1 −1 pprint/src-3/TPrintImpl.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/intent
Open in desktop
Submodule intent updated 8 files
+5 −5 src/main/scala/intent/core/equality.scala
+1 −1 src/main/scala/intent/core/expect.scala
+2 −2 src/main/scala/intent/core/formatters.scala
+2 −2 src/main/scala/intent/core/internal.scala
+3 −3 src/test/scala/intent/matchers/FailureTest.scala
+1 −1 src/test/scala/intent/matchers/ToContainTest.scala
+3 −3 src/test/scala/intent/matchers/ToEqualTest.scala
+1 −1 src/test/scala/intent/util/DelayedFutureTest.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/scodec
Open in desktop
Submodule scodec updated 2 files
+4 −4 shared/src/main/scala/scodec/Codec.scala
+5 −5 shared/src/main/scala/scodec/Transform.scala
2 changes: 1 addition & 1 deletion community-build/community-projects/shapeless
Open in desktop
Submodule shapeless updated 4 files
+1 −1 modules/deriving/src/main/scala/shapeless3/deriving/deriving.scala
+16 −16 modules/deriving/src/main/scala/shapeless3/deriving/kinds.scala
+22 −22 modules/deriving/src/test/scala/shapeless3/deriving/type-classes.scala
+14 −14 modules/typeable/src/main/scala/shapeless3/typeable/typeable.scala
4 changes: 2 additions & 2 deletions compiler/src/dotty/tools/dotc/core/TypeComparer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ class TypeComparer(@constructorOnly initctx: Context) extends ConstraintHandling
}
}
compareTypeLambda
case tp2 as OrType(tp21, tp22) =>
case tp2 @ OrType(tp21, tp22) =>
compareAtoms(tp1, tp2) match
case Some(b) => return b
case _ =>
Expand Down Expand Up @@ -970,7 +970,7 @@ class TypeComparer(@constructorOnly initctx: Context) extends ConstraintHandling
* corresponding arguments are subtypes relative to their variance (see `isSubArgs`).
*/
def isMatchingApply(tp1: Type): Boolean = tp1 match {
case tp1 as AppliedType(tycon1, args1) =>
case tp1 @ AppliedType(tycon1, args1) =>
// We intentionally do not automatically dealias `tycon1` or `tycon2` here.
// `TypeApplications#appliedTo` already takes care of dealiasing type
// constructors when this can be done without affecting type
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/core/TypeOps.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ object TypeOps:
tp.derivedAlias(simplify(tp.alias, theMap))
case AndType(l, r) if !ctx.mode.is(Mode.Type) =>
simplify(l, theMap) & simplify(r, theMap)
case tp as OrType(l, r)
case tp @ OrType(l, r)
if !ctx.mode.is(Mode.Type)
&& (tp.isSoft || l.isBottomType || r.isBottomType) =>
// Normalize A | Null and Null | A to A even if the union is hard (i.e.
Expand Down
Loading