Skip to content

Make sure that we handle relative link correctly #10470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

romanowski
Copy link
Contributor

Add better warning message in case of missing link.

We still are missing some links:

[WARN] /home/krzysiek/workspace/dotty/scala3doc/scala3-docs/index.html: Unable to resolve link 'blog/index.html' <- this is false positive
[WARN] /home/krzysiek/workspace/dotty/scala3doc/scala3-docs/index.html: Unable to resolve link 'docs/index.html' <- this is false positive
[WARN] /home/krzysiek/workspace/dotty/scala3doc/scala3-docs/docs/release-notes/0.1.2.md: Unable to resolve link '../reference/contextual/implicit-function-types.html'
[WARN] /home/krzysiek/workspace/dotty/scala3doc/scala3-docs/docs/reference/features-classification.md: Unable to resolve link 'contextual/delegates.md'
[WARN] /home/krzysiek/workspace/dotty/scala3doc/scala3-docs/docs/reference/features-classification.md: Unable to resolve link 'contextual/given-clauses.md'

@b-studios we probably should sort out that paths during documentation migration

Add better warning message in case of missing link.
@romanowski
Copy link
Contributor Author

fixes #10465

@b-studios
Copy link
Contributor

@romanowski agreed, we could restructure the content to also solve the link issues at once.

Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abgruszecki abgruszecki merged commit da9afab into scala:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants