Introduce Transparent flag
#10458
Merged
Introduce Transparent flag
#10458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
change-mixin
branch
from
3d50803 to
5cc1218
Compare
odersky
force-pushed
the
change-mixin
branch
2 times, most recently
from
16d031b to
6d5b5cd
Compare
Let the `transparent` modifier translate to it. allow `transparent` on traits and inline methods only.
For the moment, keep it in src-non-bootstrapped
Make infix a flag instead of an annotation.
odersky
force-pushed
the
change-mixin
branch
from
861d32c to
f08f00c
Compare
| * are not inferred when combined with other types in an intersection. | ||
| * See reference/other-new-features/transparent-traits.html for details. | ||
| */ | ||
| final class transparentTrait extends StaticAnnotation |
There was a problem hiding this comment.
What are the use cases for this feature?
There was a problem hiding this comment.
Essentially cross-compilation. stdLib213 already contains 9 traits that are annotated with @transparentTrait. Right now, we treat them also specially in a "assume transparent" set. But once we can backport the code into the standard library, we can drop that special treatment.
There was a problem hiding this comment.
The issue seems to be that we won't be able to drop the annotation itself. I'm not sure if that is a good idea.
| @@ -196,22 +194,22 @@ package object ops { | |||
| * val b: false ^ true = true | |||
| * ``` | |||
| */ | |||
| @infix type ^[X <: Boolean, Y <: Boolean] <: Boolean | |||
| type ^[X <: Boolean, Y <: Boolean] <: Boolean | |||
There was a problem hiding this comment.
Why are these not infix?
There was a problem hiding this comment.
They don't need to be since they are symbolic anyway.
nicolasstucki
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the
transparentmodifier translate to it. Allowtransparenton traits andinline methods only.
Fixes #10457
Also, introduce
infixas a modifier backed by a flag.Remove the @mixin and @infix annotations.