Skip to content

Fix #1037 #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2016
Merged

Fix #1037 #1038

merged 5 commits into from
Jan 23, 2016

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 19, 2016

Review by @smarter

@smarter
Copy link
Member

smarter commented Jan 19, 2016

Wow, this is interesting, after 3686713 is applied, the occasional AbstractMethodError we were seeing in some run tests are now reproducible:

> rm *.class
> ./bin/dotc tests/run/t7475b.scala
> scala -J-Xbootclasspath/a:.:target/scala-2.11/classes/ Test
java.lang.AbstractMethodError: Method Test$$anon$5.x()I is abstract
        at Test$$anon$5.x(t7475b.scala)
        at C1.$init$(t7475b.scala:3)
        at Test$$anon$5.<init>(t7475b.scala:8)
        at Test$.main(t7475b.scala:8)
        at Test.main(t7475b.scala)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at scala.reflect.internal.util.ScalaClassLoader$$anonfun$run$1.apply(ScalaClassLoader.scala:70)
        at scala.reflect.internal.util.ScalaClassLoader$class.asContext(ScalaClassLoader.scala:31)
        at scala.reflect.internal.util.ScalaClassLoader$URLClassLoader.asContext(ScalaClassLoader.scala:101)
        at scala.reflect.internal.util.ScalaClassLoader$class.run(ScalaClassLoader.scala:70)
        at scala.reflect.internal.util.ScalaClassLoader$URLClassLoader.run(ScalaClassLoader.scala:101)
        at scala.tools.nsc.CommonRunner$class.run(ObjectRunner.scala:22)
        at scala.tools.nsc.ObjectRunner$.run(ObjectRunner.scala:39)
        at scala.tools.nsc.CommonRunner$class.runAndCatch(ObjectRunner.scala:29)
        at scala.tools.nsc.ObjectRunner$.runAndCatch(ObjectRunner.scala:39)
        at scala.tools.nsc.MainGenericRunner.runTarget$1(MainGenericRunner.scala:65)
        at scala.tools.nsc.MainGenericRunner.run$1(MainGenericRunner.scala:87)
        at scala.tools.nsc.MainGenericRunner.process(MainGenericRunner.scala:98)
        at scala.tools.nsc.MainGenericRunner$.main(MainGenericRunner.scala:103)
        at scala.tools.nsc.MainGenericRunner.main(MainGenericRunner.scala)

instead of the one after it. Fixes problem with t7475b.scala
We verified that before the combination abstract/concrete for `x`
also led to AMEs. So we test it here explicitly, too.
@smarter
Copy link
Member

smarter commented Jan 23, 2016

LGTM

smarter added a commit that referenced this pull request Jan 23, 2016
@smarter smarter merged commit 8ceaba7 into scala:master Jan 23, 2016
@allanrenucci allanrenucci deleted the fix-#1037 branch December 14, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants