Skip to content

Add Flags.Opaque to reflection API #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add Flags.Opaque to reflection API #10364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/src/scala/quoted/internal/impl/QuoteContextImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2442,6 +2442,7 @@ class QuoteContextImpl private (ctx: Context) extends QuoteContext, QuoteUnpickl
def ModuleClass: Flags = dotc.core.Flags.ModuleClass
def Mutable: Flags = dotc.core.Flags.Mutable
def Object: Flags = dotc.core.Flags.Module
def Opaque: Flags = dotc.core.Flags.Opaque
def Override: Flags = dotc.core.Flags.Override
def Package: Flags = dotc.core.Flags.Package
def Param: Flags = dotc.core.Flags.Param
Expand Down
3 changes: 3 additions & 0 deletions library/src/scala/quoted/QuoteContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3184,6 +3184,9 @@ trait QuoteContext { self: internal.QuoteUnpickler & internal.QuoteMatching =>
/** Is this symbol an object or its class (used for a ValDef or a ClassDef extends Modifier respectively) */
def Object: Flags

/** Is this symbol `opaque` */
def Opaque: Flags

/** Is this symbol `override` */
def Override: Flags

Expand Down
9 changes: 1 addition & 8 deletions scala3doc/src/dotty/dokka/tasty/SyntheticSupport.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ trait SyntheticsSupport:

def isDefaultHelperMethod: Boolean = ".*\\$default\\$\\d+$".r.matches(s.name)

def isOpaque: Boolean = hackIsOpaque(using qctx)(s)
def isOpaque: Boolean = s.flags.is(Flags.Opaque)

def isInfix: Boolean = hackIsInfix(using qctx)(s)

Expand Down Expand Up @@ -77,13 +77,6 @@ trait SyntheticsSupport:
}.toList
}

def hackIsOpaque(using QuoteContext)(rsym: qctx.reflect.Symbol): Boolean = {
import dotty.tools.dotc
given dotc.core.Contexts.Context = qctx.reflect.rootContext.asInstanceOf
val sym = rsym.asInstanceOf[dotc.core.Symbols.Symbol]
sym.is(dotc.core.Flags.Opaque)
}

def hackGetSupertypes(using QuoteContext)(rdef: qctx.reflect.ClassDef) = {
import qctx.reflect._
import dotty.tools.dotc
Expand Down