Move scala.internal.{MatchCase,TypeBox} to scala.runtime. #10360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale is to get rid of the `scala.internal` package entirely, so that we don't put `internal` in everyone's scope. The change in a test highlights that `MatchCase` is observable in the macro API, which it shouldn't be, as it is an implementation detail of the compiler.
sjrd
force-pushed
the
move-scala-internal-to-runtime
branch
from
f76819d to
f361c4d
Compare
|
Assigning to @smarter since you're the dedicated reviewer for |
smarter
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale is to get rid of the
scala.internalpackage entirely, so that we don't putinternalin everyone's scope.The change in a test highlights that
MatchCaseis observable in the macro API, which it shouldn't be, as it is an implementation detail of the compiler.