Skip to content

partest: Print stack traces of swallowed exceptions #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2016

Conversation

smarter
Copy link
Member

@smarter smarter commented Jan 15, 2016

No description provided.

@smarter smarter force-pushed the fix/partest-output branch from 67805a2 to 87f6058 Compare January 15, 2016 18:38
@smarter
Copy link
Member Author

smarter commented Jan 15, 2016

Review by @DarkDimius or @odersky. The tests failed which is perfect since that means you can check that my patch actually works :)
Note: It seems that all the failures we saw recently where due to OutOfMemoryException, the first time I saw an OutOfMemoryException was with #1010 so either this PR or a slightly older one must have increased the amount of memory we use.

@odersky
Copy link
Contributor

odersky commented Jan 15, 2016

I fear there's something else. My latest pull requests have the -Xmx at 2G, but they still fail. What I see with recent commits is

  • either some memory size problem (GC overhead limit exceeded, out of Java heap space)
  • or a silent compilation failed.

The first happens for various files, the second always happens for pos/printing. I am not sure the second is also a heap problem because it persists no matter what heap size I set.

@smarter
Copy link
Member Author

smarter commented Jan 15, 2016

@odersky : this PR should at least avoid silent compilation errors, you could try rebasing on top of it

odersky added a commit that referenced this pull request Jan 16, 2016
partest: Print stack traces of swallowed exceptions
@odersky odersky merged commit 2503291 into scala:master Jan 16, 2016
@allanrenucci allanrenucci deleted the fix/partest-output branch December 14, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants