-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI generated docs on scala3doc.virtuslab.com #10276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI generated docs on scala3doc.virtuslab.com #10276
Conversation
Confoguration works on my private fork where I can control secrets. |
Could we upload to github pages like we do for the existing docs? |
Once we switch to scala3doc by default we will do that for sure. The main goal for this PR is to have generated documentation for development of scala3doc similar to what we've got on scala3doc |
@romanowski it seems we have hit a problem. I've added the secret you've sent me, but it seems that GH simply refuses to pass secrets to workflows ran from a fork, which is the default workflow for us here in Dotty land. GH docs don't suggest any workaround. A quick Google search didn't help either. I think we could try to embed the secret inside our container, but that's a bit painful to maintain. Any other suggestions? |
Merge scala3doc.yaml and ci.yaml into one file? |
@smarter I guess we can do that, but I don't understand how that is supposed to help? |
I thought from what you said that the issue was due to using a different workflow? |
The problem is that the PR references a branch on a fork of Dotty repo, which is what dotty-staging/dotty is. Workflows ran on such a PR don't get to see any secrets, not even ones in the fork apparently. |
From scala3doc. It includes documentation for dotty, scala3doc and scala3doc-testcases
7a6fd04
to
a9e45ce
Compare
And then switch to PR code to utilize secrets from main repository
a9e45ce
to
7167640
Compare
I've changed apporach and now we are now using It means that is uses CI configuration from |
Trigger for the workflow was changed to |
From scala3doc. It includes documentation for dotty, scala3doc and scala3doc-testcases
This PR requires a secret
AZURE_STORAGE_SAS_TOKEN
to be added to work.