New format of source links #10274
Merged
New format of source links #10274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
force-pushed
the
scala3doc/source-links1
branch
2 times, most recently
from
c012ad1 to
2b20382
Compare
…k to source file.We use our custom-build support for handling this instead of one from dokka.This commit also adds predefined templates for github and gitlab as well ass 'revision setting' that allows users to specify revision of documented code (and source link)
romanowski
force-pushed
the
scala3doc/source-links1
branch
from
2b20382 to
c1ef7d0
Compare
MarcinAman
reviewed
Nov 13, 2020
| s"""https://gitlab.com/$organization/$repo/-/{{ operation | replace: "view", "blob" }}/$revision/{{ path }}#L{{ line }}""" | ||
|
|
||
|
|
||
| private def parseLinkDefinition(s: String): Option[SourceLink] = ??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we use liquid templates to generate link to source file.
We use our custom-build support for handling this instead of one from dokka.
This commit also adds predefined templates for github and gitlab as well ass 'revision setting' that allows users to specify revision of documented code (and source link)