Skip to content

Fix 10256: Avoid crashing in LazyRef.ref when checking for cycles #10270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix 10256: Avoid crashing in LazyRef.ref when checking for cycles #10270

merged 1 commit into from
Nov 20, 2020
+24 −16

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 10, 2020

Report a cycle instead.

@odersky odersky requested a review from bishabosha November 10, 2020 21:53
bishabosha
bishabosha approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bishabosha bishabosha merged commit 2ea33a4 into scala:master Nov 20, 2020
@bishabosha bishabosha deleted the fix-#10256 branch November 20, 2020 14:52
@bishabosha bishabosha mentioned this pull request Nov 20, 2020
Closed
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @bishabosha @Kordyjan