Move internal Expr and Type implementations into the compiler
#10249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
move-internal-expr-type-in-compiler
branch
from
4dc0f53 to
2c5072e
Compare
liufengyun
reviewed
Nov 9, 2020
| @@ -1,17 +1,19 @@ | |||
| package scala.internal.quoted | |||
| package scala.quoted.internal | |||
There was a problem hiding this comment.
Can we put the implementation in a package e.g. dotty.tools.dotc.quotes or dotty.tools.dotc.meta?
I think it's better to not have the compiler contain a subpackage of a stdlib package.
There was a problem hiding this comment.
They need to be inside of the scala package to be able to extend the Expr and Type. Those have private[scala] constructors.
There was a problem hiding this comment.
That was the solution agreed in the meeting to avoid the need to move the compiler into the scala package.
liufengyun
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.