Skip to content

Scala3doc/fixes in scaladoc #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 11, 2020

Conversation

romanowski
Copy link
Contributor

Includes:

  • Fix rendering of .html files from static pages
  • Process links from static documentaiton corrently
  • Fix rendering of images on static pages
  • Render pages outside sidebar as well
  • Add titles in documentation pages
  • Update Highlight.js with for common languages

Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code for the PR looks good. I've found a problem with resolving links in blogs, though. On the http://localhost:8000/scala3/docs/-reference/-metaprogramming/toc.html page, all the links are broken because they have the wrong suffix - for instance, one link goes to http://localhost:8000/scala3/docs/-reference/-metaprogramming/macros.md when it should go to http://localhost:8000/scala3/docs/-reference/-metaprogramming/macros.html.

There also seems to be an issue with internal padding between border and inner text disappearing for code snippets in blogs posts. I say "disappearing", because when the page first loads the padding is still there, but after a second (possibly after hljs runs?) the padding disappears.

Static pages may have different padding values before hljs applied highlights
@romanowski romanowski merged commit 66eee84 into scala:master Nov 11, 2020
@romanowski
Copy link
Contributor Author

I've double checked and all links in https://scala3doc.virtuslab.com/pr-master/scala3/docs/-reference/-metaprogramming/toc.html works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants