Skip to content

Update docs to the new semantics of inline parameters #10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

nicolasstucki
Copy link
Contributor

Inline parameters inline the argument and hence can be inspected directly

Inline parameters inline the argument and hence can be inspected directly
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -26,7 +26,7 @@ the scope where it is used.
```scala
import scala.quoted._

inline def natConst(x: => Int): Int = ${natConstImpl('{x})}
inline def natConst(inline x: Int): Int = ${natConstImpl('{x})}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to change the title of the doc to AST Reflect, as it's done in the code to avoid obscure terms to programmers and it is more accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it in the next docs update PR

@nicolasstucki nicolasstucki merged commit 67bd66f into scala:master Nov 8, 2020
@nicolasstucki nicolasstucki deleted the update-reflect-docs branch November 8, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants