Check all bounds and avoid infinite subtyping checks when intersecting denotations #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@smarter This kind of recursion, which is problematic, is only allowed for F-bounded upper types. So we always have a typebound. |
smarter
force-pushed
the
fix/deep-subtypes
branch
from
4892639 to
534276d
Compare
| val tparams = tycon.tpe.typeSymbol.typeParams | ||
| val bounds = tparams.map(tparam => | ||
| tparam.info.asSeenFrom(tycon.tpe.normalizedPrefix, tparam.owner.owner).bounds) | ||
| checkBounds(args, bounds, _.substDealias(tparams, _)) |
There was a problem hiding this comment.
I think you need to call traverseChildren(tree) here too, otherwise the following compiles without errors:
class OnlyInt[T <: Int]
object Test {
type T = List[OnlyInt[String]]
}
|
Otherwise LGTM, I rebased the PR, addressed your style comment, and added a description to |
|
/rebuild |
smarter
force-pushed
the
fix/deep-subtypes
branch
2 times, most recently
from
2ee486d to
5c6fe12
Compare
|
Rebased, note that there are two unadressed comments that github is hiding: |
smarter
force-pushed
the
fix/deep-subtypes
branch
from
5c6fe12 to
14a671a
Compare
|
@smarter Is this good to merge now? |
This is important for IDEs who want to see the full tree. The tree now gets replaced by a TypeTree in PostTyper.
Previously, bounds of a TypeDef tree were not checked. We now make sure bounds are checked everywhere in PostTyper. The previous partial check in Applications gets removed (it was not complete even for TypeApplications because sometimes bounds were not yet known when the test was performed.)
Checking bounds everywhere revealed a problem in compileStdLib, which this commit fixes.
New test that exhibited the problem is ski.scala. Previously this did not fail with a bounds violation.
This allows us to run compileStdLib without deep subtypes again.
smarter
force-pushed
the
fix/deep-subtypes
branch
from
14a671a to
06e18c6
Compare
smarter
force-pushed
the
fix/deep-subtypes
branch
from
bb59d81 to
8141e62
Compare
|
Oops, pushed the wrong commit, please review 8141e62 instead. |
smarter
force-pushed
the
fix/deep-subtypes
branch
from
8141e62 to
224232d
Compare
|
Merging, the junit failure is due to scala/scala-jenkins-infra#158 but you can check that the tests actually succeeded so it's safe. |
smarter
added a commit
that referenced
this pull request
Jan 18, 2016
Check all bounds and avoid infinite subtyping checks when intersecting denotations
smarter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1012
Review by @odersky, I don't actually understand why
safeAndis safer than&but it seems to work well in practice, could you explain why it works so that I can add a comment?