Skip to content

Add a compiler.properties resource file like in Scala 2 #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2016

Conversation

smarter
Copy link
Member

@smarter smarter commented Dec 30, 2015

Review by @DarkDimius .

@smarter smarter force-pushed the add/sbt-stuff branch 2 times, most recently from 90ae286 to 75a6ffe Compare December 30, 2015 20:59
@smarter smarter changed the title Small changes to make it easier for sbt to use dotty as a compiler Add a compiler.properties resource file like in Scala 2 Dec 30, 2015
@smarter
Copy link
Member Author

smarter commented Dec 30, 2015

/rebuild

This is used by sbt to get the compiler's version.

The code to generate the resource comes from
http://www.scala-sbt.org/0.13/docs/Howto-Generating-Files.html#Generate+resources
@DarkDimius DarkDimius self-assigned this Jan 3, 2016
@DarkDimius
Copy link
Contributor

@smarter would you kindly update dotc.build test to carry over the generated file to bootstrapped dotty?

Otherwise LGTM

@DarkDimius DarkDimius removed their assignment Jan 4, 2016
@smarter
Copy link
Member Author

smarter commented Jan 4, 2016

@smarter would you kindly update dotc.build test to carry over the generated file to bootstrapped dotty?

This is slightly tricky because the generated file is in target/scala-2.11/resource_managed, but if we compile dotty with dotty it'll be in target/scala-0.1/resource_managed, since this resource is only useful for using dotty from sbt, and since the jar generated by test/dotc/build.scala is incomplete and cannot be used from sbt anyway, I'd rather not hack on this for now.

smarter added a commit that referenced this pull request Jan 4, 2016
Add a compiler.properties resource file like in Scala 2
@smarter smarter merged commit 66e02a5 into scala:master Jan 4, 2016
@allanrenucci allanrenucci deleted the add/sbt-stuff branch December 14, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants