The atom of a module class is its module val #10106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `firstTry` we've long had the following special-case:
if (sym1.is(ModuleClass) && sym2.is(ModuleVal))
// For convenience we want X$ <:< X.type
// This is safe because X$ self-type is X.type
sym1 = sym1.companionModule
It turns out that this isn't enough nowadays because `atoms` on a module
class returned `Atoms.Unknown` so `X$ | Y$ <:< X.type | Y.type` returned
false. This commit fixes this by special-casing `atoms` for module
classes. Alternatively, we could drop all special-casing of module
classes and module vals in the subtype checker, but that would require
making sure that we never widen module vals anywhere which seems tricky.
smarter
force-pushed
the
fix-module-class-atom
branch
from
43fa599 to
ef468bc
Compare
odersky
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
firstTrywe've long had the following special-case:It turns out that this isn't enough nowadays because
atomson a moduleclass returned
Atoms.UnknownsoX$ | Y$ <:< X.type | Y.typereturnedfalse. This commit fixes this by special-casing
atomsfor moduleclasses. Alternatively, we could drop all special-casing of module
classes and module vals in the subtype checker, but that would require
making sure that we never widen module vals anywhere which seems tricky.