Subtle changes to TypeComarer needed for Linker. #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linker needs to resolve super calls before they are rewritten in the tree.
| override def derivedSelect(prefix: Type)(implicit ctx: Context): Type = | ||
| if (prefix eq this.prefix) this | ||
| else { | ||
| ??? |
There was a problem hiding this comment.
In linker this didn't yet happen: the prefix that this type starts with is very precise type and it should not loose precision by getting less precise prefix.
There was a problem hiding this comment.
If this happens, I would need to start looking into changes to derivedSelect from #1001
Motivation comes from Linker: List$.canBuildFrom is implemented as ReusableCBF.asInstanceOf[GenericCanBuildFrom[A]] static type of field ReusableCBF here is TypeRef(TypeRef(List$), GenericCanBuildFrom[Nothing]) but the ident ReusableCBF gets type TypeRef(ThisType(List$), GenericCanBuildFrom[Nothing]) We already permit comparisons between static TermRefs and ThisTypes, this change additionally allows TypeRefs to static modules to become subtypes of ThisTypes of static modules.
DarkDimius
force-pushed
the
linker/types
branch
from
9714565 to
f0c6814
Compare
|
@odersky please have a look and merge if LGT you. |
|
LGTM. |
odersky
added a commit
that referenced
this pull request
Jan 6, 2016
Subtle changes to TypeComarer needed for Linker.
|
For the record, I was working in this space in scalac recently: scala/scala@2.12.x...retronym:ticket/9542-combo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@odersky those are the changes that are result of our discussion last Friday.
Only 9714565 is new here, it allows NamedTypes to static modules to be subtypes
of ThisTypes of static modules. This was already allowed for TermRefs.
The commit comment has a motivation example from stdlib.
@odersky please review.