Skip to content

Only run the sbt scripted tests and CB when publishing sbt-dotty #10025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 16, 2020

Everything else is independent of sbt-dotty working or not.

@smarter smarter force-pushed the simplify-sbt-publish branch 3 times, most recently from d15fef4 to 0b8a987 Compare October 16, 2020 13:53
@@ -210,11 +218,12 @@ jobs:
test_java8:
runs-on: [self-hosted, Linux]
container: lampepfl/dotty:2020-04-24
if: (
if: "(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes are needed when using ! apparently

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Everything else is independent of sbt-dotty working or not.
@smarter smarter force-pushed the simplify-sbt-publish branch from 0b8a987 to 3f74aa8 Compare October 16, 2020 16:12
@smarter smarter merged commit fefa7c5 into scala:master Oct 16, 2020
@smarter smarter deleted the simplify-sbt-publish branch October 16, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants