creating file paths with embedded colons illegal under windows

[philwalk]

The following code sequence in compile/test/dotty/tools/dotc/reporting/TestReporter.scala, lines 89 through 92 attempts to create a file with multiple embedded colons, throwing an exception in Windows:

    val df1 = new SimpleDateFormat("yyyy-MM-dd-HH:mm:ss")
    val folder = s"../testlogs/tests-${df0.format(date)}"
    new JFile(folder).mkdirs()
    outFile = new JFile(s"$folder/tests-${df1.format(date)}.log")
    outFile.createNewFile // added to trigger java.io.IOException locally, not in TestReporter.scala

Here's the exception:
java.io.FileNotFoundException: ..\testlogs\tests-2017-10-23\tests-2017-10-23-10:18:51.log (The filename, directory name, or volume label syntax is incorrect)

replacing colons with hyphens (or other legal path characters) in the SimpleDateFormat seems to fix the problem.

[allanrenucci]

Could you give a fully compilable code snippet with which we can reproduce the issue?

[philwalk]

I'm happy to provide a compilable code snippet (it will have to wait until I return to the office in a few hours). In the interim, you can reproduce it via "sbt test" under Windows. Alternately, you could replace the colons in the date format string with any character not legal as part of a path and you should be able to get the same exception via "sbt test" on linux or osx.

[philwalk]

I'm working on a minimal source file that reproduces the problem, but in the meantime, I added one more line to the end of the sequence of code above, which is needed to trigger the exception. Here's my candidate class file, which will compile, but it throws an exception at runtime (only tested in scala so far, am working on verifying things in dotty). Save this code to Bug.scala and it should do the trick.

object BadFilenameWindows extends App {
  import java.text.SimpleDateFormat
  import java.util.Date
  type JFile = java.io.File

  val date = new Date
  val df0 = new SimpleDateFormat("yyyy-MM-dd")
  val df1 = new SimpleDateFormat("yyyy-MM-dd-HH:mm:ss")
  val folder = s"../testlogs/tests-${df0.format(date)}"
  new JFile(folder).mkdirs()
  val outFile = new JFile(s"$folder/tests-${df1.format(date)}.log")
  outFile.createNewFile // this is where the java.io.IOException is thrown
}

[philwalk]

Judging by the path /mnt/c/Users/... I'm guessing that #3349 occurs on Windows Subsystem for Linux, which permits colons in filenames, so it would seem to be unrelated to #3349

…

On Tue, Oct 24, 2017 at 8:15 AM, rsoeldner ***@***.***> wrote: isn't this related to #3349 <#3349> ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3373 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADBlltUTdSt4t9XM_v3v_2UNKLc4O3AZks5svfDngaJpZM4QDYJJ> .

[philwalk]

Following up on the previous comment (I was unable to edit it without losing code formatting):

The relevant difference between the two cases is that a cygwin test uses the Windows JVM, but in WSL, it would be an Ubuntu/Linux .deb JVM distribution installed by apt, etc. Here's a scala script that fails under cygwin and passes under WSL:

object ColonFilename extends App {
  val file = new java.io.File("1:2:3")
  file.createNewFile
}

[allanrenucci]

It doesn't look like an issue with Dotty issue nor an issue with Scala. I suppose it doesn't work either with Java. If so, there is nothing we can do about it

[smarter]

Of course there is something we can do about it. Just change the generated file name to not use :

[allanrenucci]

My bad, I misunderstood the issue...