Show the real git hash in the REPL welcome message, when running `repl` or `bin/dotr`

[dwijnand]

Currently when running repl or bin/dotr the REPL shows:

Welcome to Scala.next (pre-alpha, git-hash: unknown)  (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_121).

The reason is that the git hash is defined in terms of the JAR manifest, which isn't present.

Possible solutions include:

• moving to a generated properties file instead of the manifest (what Scala does)
• package the jar and run the REPL from the jar instead
• some other solution involving a temporarily generated MANIFEST.MF

[felixmulder]

Thanks for reporting Dale!

Currently not at work, but quick answer: this was solved already. There's a PR by an external contributor that solved this.

We should find out why it's no longer working.

[dwijnand]

Do you mean #1571 ?

[felixmulder]

Yes! :)

…

On Sun, Apr 23, 2017, 16:14 Dale Wijnand ***@***.***> wrote: Do you mean #1571 <#1571> ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2291 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdYwebp2qdgfGVgEJsmT-hgwqvwmJM_ks5ry1zVgaJpZM4NFK80> .

[dwijnand]

That's still the current implementation, and that works fine from JAR (I assume).

This issue is an enhancement request that it does better than "git-hash: unknown" when running repl or bin/dotr.

[felixmulder]

Then bin/dotr should be working, since it uses the jar...hmm. Will have to investigate.

[dwijnand]

You're right, the problem is only in repl.

$ bin/dotr
The script is going to build the required jar files
Building dotty-interfaces...done
Building dotty-compiler...done
Building dotty library...done
Building tests...done
Starting dotty REPL...
Welcome to Scala.next (pre-alpha, git-hash: 9195e91)  (Java HotSpot(TM) 64-Bit Server VM, Java 1.8.0_121).
Type in expressions to have them evaluated.
Type :help for more information.
scala>

[felixmulder]

Then perhaps it is fine since repl is only a task used locally in the Dotty project. All projects using the Dotty compiler and bridge will get a console task via sbt that should say the correct thing...But I guess you're the expert on that.

WDYT?

[dwijnand]

The need to run the REPL straight out of the dotty repo will certainly decrease after the initial official releases of Dotty. But for both now and later I think this feature would be convenient, mostly when sharing REPL snippets.