optional braces no longer work in repl

[bishabosha]

Compiler version

3.7.0-RC1, 3.7.1-RC1-bin-20250319-270fc87-NIGHTLY

Minimized code

paste this code into the repl, it is impossible to execute the code by pressing return key, the editor just keeps adding newlines.

object foo:
  val bar = 23

Output

scala> object foo:
     |   val bar = 23
     | 
     | 
     | 
     | 
     | 
     | 
     | 
     | 
     | 

Expectation

work as in 3.6.4

[bishabosha]

it would also suggest either repl tests do not test optional braces, or that they do not simulate keyboard entry

[Gedochao]

Tricky to bisect... @dwijnand any clue what could cause this behaviour change?

[Gedochao]

Last good version: 3.7.0-RC1-bin-20250128-9cb97ec-NIGHTLY
First bad version: 3.7.0-RC1-bin-20250129-81e057a-NIGHTLY

• the first bad commit is 81e057a (No outdent at eof #22435)

@som-snytt I'll assign you for now, let me know if you'll have the time to take a look

[som-snytt]

Thanks, I'll take a look.

Since a long time, I always use braces in REPL. Sometimes I use extra braces.

I don't see REPL tests at all offhand. In Scala 2, REPL tests are a sub-ecosystem. (Edit: forgot they are unit tests under compiler/test.)

(Edit: I see I opened #13097 which is when I stopped using advanced features in REPL, even though I knew that issue was fixed. It was a case of fool me once.) (I also tweaked something recently in the same area of EOL followed by indent, but did not consider REPL at all. I remember wondering about the special check for EOL: that was to accommodate REPL, since EOL is EOF.)

[SethTisue]

Ah, thanks for reporting this, I had noticed it and then got sidetracked :-/

It's pretty bad... I think it should be considered a blocker for 3.7.0.