`MarkdownLinkVisitor` mismatch on member named `md`

[felixmulder]

In MarkdownLinkVisitor.scala we do two things:

1. Replace relative/path/to/markdown.md with relative/path/to/markdown.html
2. Member lookup on [isEmpty](scala.collection.immutable.Seq.isEmpty)

The first one is simply caught with .endsWith(".md"), which means you cannot call a package member md.

[Varunram]

@felixmulder What are your suggestions? Maybe read the whole string and do something?

[felixmulder]

Well, we need to be able to distinguish between links that are part of the site as markdown templates ending in .md (later transformed to HTML) and actual source code in a package like:

package blabla

object md {
}

Where the object will have the path blabla.md and as such if referred to in another markdown file with: [md](blabla.md); that link will be transformed to <a href="{{ site.baseurl}}/api/blabla/md.html">md</a> or something similar.

[Varunram]

Thanks for clarifying. What I thought was maybe we could add a try catch loop with Reflection and see if there exists a package. Would this be the right approach?

[felixmulder]

You won't know via reflection, as there is no loading of the compiled sources into the classloaders. You could do:

ctx.getClassIfDefined(str).exists

To see if the class exists in the current compilation unit or on the classpath.

[Varunram]

Thanks! I'll test it up front and put in a PR later today

[Varunram]

Okay, so I worked on this and get the error required: dotty.tools.dotc.core.Names.PreName. What I did was I cut the last three characters off the URL (after using lastIndexOf obviously) and placed them in str. What am I doing wrong here?

[felixmulder]

Could you show me the code snippet? I'm not sure I follow.

[Varunram]

          val url = node.getUrl
          if(url.endsWith(".md")) {
            val x = new URI(url.toString)
            val path = x.getPath()
            val meth = path.substring(path.lastIndexOf('/')+1).dropRight(3);
            implicit ctx: Context => ctx.getClassIfDefined(meth).exists

I think I'm not handling the last line properly. Earlier I just had an _ but that doesn't do anything, so I thought I'd replace it with meth.isExists

[felixmulder]

well the last line produces a function from Context => Boolean, where the Context is marked implicit, but the function is not applied.

The function which contains this code should take a second parameter list (implicit ctx: Context)

[Varunram]

The error statement : Exception in thread "main" java.lang.ClassCastException: java.lang.String cannot be cast to dotty.tools.dotc.core.Names$PreName. Why can't I cast to Name.preName?