Skip to content

Bring back some disabled ScalaTest tests #14712

Closed
@odersky

Description

@odersky

Compiler version

3.1.3-RC2

Description

I also had to disable in #14695 two scalatest tests: ExpectationsSpec and DirectExpectationsSpec. These were test suites containing tests that checked the precise error message output of the dotty compiler. IMO such tests should never be in a regression test suite for the community build, since they essentially lock in current behavior. We do want tests about error messages of course, but these should be compiler tests that can easily be changed if the compiler's error diagnostics improve.

Not knowing scalatest. I was not able to figure out from the diagnostics which particular tests broke in the two suites, so I disabled them wholesale. It would be good to bring back those tests in ExpectationsSpec and DirectExpectationsSpec of scalatest that do not depend on specific error diagnostics of dotc.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions