deprecated case class warns at its definition

[bishabosha]

Minimized code

@deprecated("no CaseClass", "0.1") case class CaseClass(rgb: Int)

Output

-- Deprecation Warning: CaseClass.scala:1:0 ----
21 |@deprecated("no CaseClass", "0.1") case class CaseClass(rgb: Int)
   |^
   |class CaseClass is deprecated since 0.1: no CaseClass
-- Deprecation Warning: CaseClass.scala:1:46 ---
21 |@deprecated("no CaseClass", "0.1") case class CaseClass(rgb: Int)
   |                                              ^
   |                   class CaseClass is deprecated since 0.1: no CaseClass

Expectation

no warning as in Scala 2.13.4.

[gregbeech]

This is also an issue for deprecated implicit classes. I assume it's the same basic issue so I'll just add this as a comment rather than opening a new issue.

Minimized Code

object repro {
  @deprecated("no ImplicitClass", "0.1") implicit class ImplicitClass(val a: Any)
}

Output

[warn] 2 |  @deprecated("no ImplicitClass", "0.1") implicit class ImplicitClass(val a: Any)
[warn]   |  ^
[warn]   |class ImplicitClass in object repro is deprecated since 0.1: no ImplicitClass

Expectation

No warning, as in Scala 2.13.6

[SethTisue]

would this be a good issue-spree ticket?

[som-snytt]

I was going to address it after scala/scala#10071 which ... how did I put it ...

Instead of juggling annotations, the deprecation loophole is expanded to look more like the tax code.

[He-Pin]

Any update about this @som-snytt ,thanks.

[som-snytt]

@He-Pin by coincidence, yesterday I deleted the old branch from a year ago, but got distracted by warning on deprecated constant-folded ops. I'll return to this right after that. The interesting lesson from that other fix is that because of structural differences in the pipeline, fixes don't necessarily forward-port directly.