-
Notifications
You must be signed in to change notification settings - Fork 47
Swingtut #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Swingtut #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The subproject containing the examples (added in 8db44f3) is not aggregated under the root project, and as such is not part of `sbt compile`. This commit adds the task `examples/compile` to the SBT command line in the Travis CI build.
…ym/scala-swing into swingtut Merge of a large number of tutorial examples.
…y the SwingWorker in IconDemoApp.scala. It is getting called now.
…x swing custom actions attatched to menu item peers.
…nu item peers or action peers. Use Swing.onEDT to place this computation on the Swing event dispatch thread. Fix the caret event handling.
…wing component in its own right. Change the source code and html for the TextSampleDemo so that it refers to scala.swing components instead of swing jcomponents.
… Option.None is returned.
… FileChooserDemo2 which is not scalified yet.
… more dot files that we do not want in git.
…e ActionDemo so that scala-swing events are used instead of an ActionListener.
…igationIcon function.
The changes in this pull request can be merged easily using local git commands into my java7 branch if you decide that is easier. |
BorderDemo demo
…t accessed MainFrame's peer. Used the right scala-swing code to do alignment, improving the appearance of some applications and also removing more accesses to various component peers. Added new tutorials for layouts.
can be done using the function makeEditable.
of stray references to java files with references to scala files.
splitpanes used in SplitPaneDemo, SplitPaneDemo2, and SplitPaneDividerDemo.
…n was fixed and some stray comments were removed.
…l. One bug fix in the handler for the Set button that showed up when the button is clicked without choosing a name in the list.
Sciss
added a commit
to Sciss/scala-swing
that referenced
this pull request
Apr 28, 2018
- bump version to 2.0.4-SNAPSHOT (mima binary compat checks) - add `Font` object, because having `scala.swing._` in scope means we cannot use static methods of `java.awt.Font` any longer. - add some documentation to `Table` - add another constructor with table-model to `Table` - add a few missing methods to `Table` (`rowMargin`, `viewToModelRow`, `modelToViewRow`, `autoCreateRowSorter`, `updateSelectionOnSort`) - fix `apply` and `update` to convert between row model and view - add programmatic `sort` method. - fixes scala#20, fixes scala#47, fixes scala#62 - add uitest to verify sorting and converting indices works correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly all of the changes recommended on review are included in this commit. The only exception: the recommendation that examples/src/main/scala/scala/swing/examples/tutorials/components/BorderDemo.scala use scala-swing constants instead of swing constants was not applicable. It may be possible to replace some more of the var declarations with val declarations, but I did not know how.