Skip to content

SI-8019 Make Publisher check PartialFunction is defined for Event #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rtyley
Copy link
Contributor

@rtyley rtyley commented Dec 9, 2013

copied from scala/scala#3205 - @adriaanm points out that this is the current repo for scala-swing

Reactions are PartialFunctions, so if events come through indiscriminately that the listener is not defined for, errors occur. Eg:

Exception in thread "AWT-EventQueue-0" scala.MatchError: FocusGained(scala.swing wrapper scala.swing.TextField

A Coursera thread with people affected by this issue: https://class.coursera.org/reactive-001/forum/thread?thread_id=1315

I've signed the Scala CLA.

Reactions are PartialFunctions, so if events come through
indiscriminately that the listener is not defined for, errors occur. Eg:

--
Exception in thread "AWT-EventQueue-0" scala.MatchError: FocusGained(scala.swing wrapper scala.swing.TextField
--

A Coursera thread with people affected by this issue:

https://class.coursera.org/reactive-001/forum/thread?thread_id=1315
@adriaanm
Copy link
Contributor

adriaanm commented Dec 9, 2013

Thanks, @rtyley!

adriaanm added a commit that referenced this pull request Dec 9, 2013
…fined

SI-8019 Make Publisher check PartialFunction is defined for Event
@adriaanm adriaanm merged commit f0246d3 into scala:master Dec 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants