scala.swing.Table column sorts are broken

[jacobsallan]

Invoking javax.swing.JTable (or hiding this invocation in scala.swing.Table) causes the table head to change to enable sorting. Selecting a row before clicking on the table head makes the selection highlighting to move. But the data in the rows does not move. The code below works with the java7 branch (October 19, 2014). It is possible to get rid of the remaining peer calls with simple modifications to the source.

[jacobsallan]

/*

• Copyright (c) 1995, 2008, Oracle and/or its affiliates. All rights reserved.
  *
• Redistribution and use in source and binary forms, with or without
• modification, are permitted provided that the following conditions
• are met:
  *
• • Redistributions of source code must retain the above copyright

• notice, this list of conditions and the following disclaimer.
  
• • Redistributions in binary form must reproduce the above copyright

• notice, this list of conditions and the following disclaimer in the
  

• documentation and/or other materials provided with the distribution.
  
• • Neither the name of Oracle or the names of its

• contributors may be used to endorse or promote products derived
  

• from this software without specific prior written permission.
  
• THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
• IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
• THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
• PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
• CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
• EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
• PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
• PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
• LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
• NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
• SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
  package scala.swing.examples.tutorials.components

import scala.swing._
import scala.swing.event.MouseClicked
import javax.swing.event.TableModelListener
import javax.swing.table.DefaultTableModel

/**

• Tutorial: How to Use Tables

• [[http://docs.oracle.com/javase/tutorial/uiswing/components/table.html]]

• Source code references:

• [[http://docs.oracle.com/javase/tutorial/uiswing/examples/components/TableSortDemoProject/src/components/TableSortDemo.java]]

• TableSortDemo.scala requires no other files.
  */
  class TableSortDemo extends GridPanel(1, 0) {
  private val Debug = false

  val table = new Table(5, 5) {
  model = new MyTableModel()
  preferredViewportSize = new Dimension(500, 70)
  }
  table.peer.setFillsViewportHeight(true)
  table.peer.setAutoCreateRowSorter(true)
  if (Debug) {
  listenTo(table)
  reactions += {
  case e: MouseClicked => table.model.asInstanceOf[MyTableModel].printDebugData(table)
  }
  }

  //Create the scroll pane and add the table to it.
  val scrollPane = new ScrollPane(table)

  //Add the scroll pane to this panel.
  contents += scrollPane

  class MyTableModel extends DefaultTableModel {
  val columnNames: Array[String] = Array("First Name",
  "Last Name",
  "Sport",
  "# of Years",
  "Vegetarian")
  val data: Array[Array[Any]] = new ArrayArray[Any]
  data(0) = Array("Kathy", "Smith", "Snowboarding", 5, false)
  data(1) = Array("John", "Doe", "Rowing", 3, true)
  data(2) = Array("Sue", "Black", "Knitting", 2, false)
  data(3) = Array("Jane", "White", "Speed reading", 20, true)
  data(4) = Array("Joe", "Brown", "Pool", 10, false)

  override def getColumnCount(): Int = { columnNames.length }
  override def getRowCount(): Int = { if (data == null) 0 else data.length }
  override def getColumnName(col: Int): String = { columnNames(col) }
  override def getValueAt(row: Int, col: Int): Object = {
  col match {
  case 0 => data(row)(col).asInstanceOf[java.lang.String]
  case 1 => data(row)(col).asInstanceOf[java.lang.String]
  case 2 => data(row)(col).asInstanceOf[java.lang.String]
  case 3 => data(row)(col).asInstanceOf[java.lang.Integer]
  case 4 => data(row)(col).asInstanceOf[java.lang.Boolean]
  }
  }
  /*

  • JTable uses this method to determine the default renderer/

  • editor for each cell. If we didn't implement this method,

  • then the last column would contain text ("true"/"false"),

  • rather than a check box.
    /
    override def getColumnClass(c: Int): Class[] = {
    getValueAt(0, c).getClass
    }
    override def isCellEditable(row: Int, col: Int): Boolean = {
    //Note that the data/cell address is constant,
    //no matter where the cell appears onscreen.
    if (col < 2) {
    return false;
    } else {
    return true;
    }
    }
    override def addTableModelListener(l: TableModelListener): Unit = {}
    override def removeTableModelListener(l: TableModelListener): Unit = {}
    /_

  • Don't need to implement this method unless your table's

  • data can change.
    */
    override def setValueAt(value: java.lang.Object, row: Int, col: Int): Unit = {
    if (Debug) {
    println("Setting value at " + row + "," + col +
    " to " + value +
    " (an instance of " +
    value.getClass() + ")")
    }
    data(row)(col) = value
    // Normally, one should call fireTableCellUpdated() when
    // a value is changed. However, doing so in this demo
    // causes a problem with TableSorter. The tableChanged()
    // call on TableSorter that results from calling
    // fireTableCellUpdated() causes the indices to be regenerated
    // when they shouldn't be. Ideally, TableSorter should be
    // given a more intelligent tableChanged() implementation,
    // and then the following line can be uncommented.
    // fireTableCellUpdated(row, col);
    if (Debug) {
    println("New value of data:")
    printDebugData(table)
    }
    }
    def printDebugData(table: Table): Unit = {
    val numRows = table.rowCount
    val numCols = table.peer.getColumnCount()
    val model: javax.swing.table.TableModel = table.model

    println("Value of data: ")
    for (i <- 0 until numRows) {
    System.out.print(" row " + i + ":")
    for (j <- 0 until numCols) {
    print(" " + model.getValueAt(i, j))
    }
    println()
    }
    println("--------------------------")
    }
    }

}

object TableSortDemo extends SimpleSwingApplication {
lazy val top = new MainFrame() {
title = "TableSortDemo"
contents = new TableSortDemo()
}
}