This repository was archived by the owner on Sep 8, 2022. It is now read-only.
don't run mima #65
Merged
don't run mima #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
review by @szeiger |
|
Hm, what triggered MiMa in the first place? I don't see any command for it |
|
it's in the scala-module-plugin sbt plugin: https://github.com/scala/sbt-scala-modules/blob/master/src/main/scala/ScalaModulePlugin.scala#L113 |
|
@lrytz I looked up when MiMa got enabled to ask the author why it was done in the first place. It turns out it was you in lrytz@9bd6c57. LGTM. |
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
don't run mima
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.