This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Make nest.Runner#runCommand protected #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to override `def javac` in dotty
smarter
changed the title
smarter
force-pushed
the
runCommand-public
branch
from
141332a to
83578ab
Compare
|
I'm not up to speed, but I noticed this old code for picking javac: |
|
The reason for overriding javac in dotty is because our classpath is set up differently and we need to pass |
|
They're missing a light-bulb icon, the complement to the confused face. |
|
LGTM |
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Make nest.Runner#runCommand protected
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Make nest.Runner#runCommand protected
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to override
def javacin dotty