This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Avoid "".lines ambiguity #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, "normalizing" the log file and "filtering" the check file rely on `"".lines.isEmpty` to represent an absent or empty file. This commit avoids extracting lines from an empty string.
|
Not urgent since the other PR is closed. But maybe the call sites look cleaner. Certainly the empty string handling was confusing, given partest's too-many moving parts. |
|
LGTM |
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Avoid "".lines ambiguity
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Avoid "".lines ambiguity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "normalizing" the log file and "filtering" the check
file rely on
"".lines.isEmptyto represent an absent or emptyfile. This commit avoids extracting lines from an empty string.