Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

Report more errors on invalid .flags files #46

Merged
merged 1 commit into from
Jan 29, 2016

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Jan 26, 2016

In particular

  • report an error if a .flags file contains non-compiler-options
    (arguments that would normally be files, i.e., not starting with -)
  • report errors that occur while parsing an individual setting's
    arguments, i.e., -Yopt:someTypo

In particular
  - report an error if a .flags file contains non-compiler-options
    (arguments that would normally be files, i.e., not starting with -)
  - report errors that occur while parsing an individual setting's
    arguments, i.e., -Yopt:someTypo
@lrytz
Copy link
Member Author

lrytz commented Jan 26, 2016

I tested it locally. Once we have a release we can add a neg test to the scala/scala that has an invalid .flags file. Review by @SethTisue

lrytz referenced this pull request in lrytz/scala Jan 27, 2016
lrytz referenced this pull request in lrytz/scala Jan 27, 2016
SethTisue added a commit that referenced this pull request Jan 29, 2016
Report more errors on invalid .flags files
@SethTisue SethTisue merged commit 44bc639 into scala:master Jan 29, 2016
retronym added a commit to retronym/scala-partest that referenced this pull request Feb 12, 2016
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Add a filter for a MiMa error that has snuck through.
    The change itself seems harmless enough, the constructor
    that was removed is from a class that was effectively internal
    to partest's implementation. See scala#46
retronym added a commit to retronym/scala-partest that referenced this pull request Feb 12, 2016
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Add a filter for a MiMa error that has snuck through.
    The change itself seems harmless enough, the constructor
    that was removed is from a class that was effectively internal
    to partest's implementation. See scala#46
retronym added a commit to retronym/scala-partest that referenced this pull request Feb 12, 2016
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Restore a binary incompatible change made in
    scala#46
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
Report more errors on invalid .flags files
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Restore a binary incompatible change made in
    scala#46
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
Report more errors on invalid .flags files
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Restore a binary incompatible change made in
    scala#46
lrytz pushed a commit to lrytz/scala that referenced this pull request May 9, 2018
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Restore a binary incompatible change made in
    scala/scala-partest#46
lrytz pushed a commit to lrytz/scala that referenced this pull request May 9, 2018
  - Bump sbt-scala-modules version (to get to a new version of MiMa)
  - Bump the snapshot version
  - Bump the previous MiMa version to 1.0.11
  - Restore a binary incompatible change made in
    scala/scala-partest#46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants