enable -Xfatal-warnings #38
Conversation
namely "possible missing interpolator: detected interpolated identifier"
we are finally free to do this, now that `-deprecation:false` exists
despite the stern warnings warning in build.sbt, we have no such warnings currently
|
review by @adriaanm, review and/or umlaut jokes by @som-snytt |
| @@ -765,7 +765,7 @@ class SuiteRunner( | |||
|
|
|||
| def banner = { | |||
| val baseDir = fileManager.compilerUnderTest.parent.toString | |||
| def relativize(path: String) = path.replace(baseDir, "$baseDir").replace(PathSettings.srcDir.toString, "$sourceDir") | |||
| def relativize(path: String) = path.replace(baseDir, s"$$baseDir").replace(PathSettings.srcDir.toString, "$sourceDir") | |||
There was a problem hiding this comment.
Even without the PR for the constant folding f-interpolator, f"$$x" is a constant string.
There was a problem hiding this comment.
I meant: as a style matter, I prefer f"constant" because s"constant" involves a string context.
There was a problem hiding this comment.
yeah, I understood and thought about changing it, but decided I like it a little better this way, just because s is so much more familiar than f. (no strong feeling either way though)
There was a problem hiding this comment.
I guess it's time to apply my f"the familiar interpolator" sticker to the lid of my lap top.
|
LGTM! I pondered @som-snytt's comment for a while, but afraid the umlaut flew over my head. |
|
I had an incongruous umlaut once, but I saw a doctor and got rid of it. |
enable -Xfatal-warnings
enable -Xfatal-warnings
No description provided.