-
Notifications
You must be signed in to change notification settings - Fork 27
SI-7566 Remove use of String=>TermName implicit #27
Conversation
Review by @adriaanm? |
LGTM. Thanks, @soc! |
SI-7566 Remove use of String=>TermName implicit
@adriaanm What's the appropriate way to release a new partest version now? |
Create a release on github and let travis do its thing, then sign in to sonatype and promote the staged release to maven (last manual step that someone from the core team needs to do). I have this on my TODO for this week, but if you'd like to do it, I'll add you to the committers here (if that isn't the case yet) so you can do it. |
Mhh, is https://github.com/soc/scala-partest/compare/scala:master...soc:topic/release-1.0.3?expand=1 going into the right direction? I set the version to 1.0.3, and created a tag called v1.0.3. So what would be the next thing? Regarding that Sonatype thing, I only have an account for http://private-repo.typesafe.com, I guess that's something different? |
Thanks for taking this on -- sorry I wasn't clear! I was talking specifically about the "Release" page on github. The only required action from the module maintainer is pushing a tag (which the Release page lets you do from the web), and the automation does the rest (on Travis), all the way to staging a repo on sonatype. It doesn't promote that repo to maven central -- that's something only the core team can do. So, I'll add you to the team that can push tags/merge PRs for partest, and you can cut the release! |
Ok, thanks for the info. But I still have to change the version info |
No, the release automation derives the version from the tag. We do need to On Wed, Dec 10, 2014 at 9:12 AM, soc notifications@github.com wrote:
|
Ok, did the release! https://github.com/scala/scala-partest/releases/tag/v1.0.3 |
Cool, thanks! Released to maven central. Could you submit a PR to scala/scala to update versions.properties? |
Yes! :-) Both 2.11 and 2.12 or just 2.12? |
both, but I wouldn't change this in 2.11.5 at this point |
SI-7566 Remove use of String=>TermName implicit
SI-7566 Remove use of String=>TermName implicit
No description provided.