Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

SI-7566 Remove use of String=>TermName implicit #27

Merged
merged 1 commit into from
Dec 8, 2014
Merged

SI-7566 Remove use of String=>TermName implicit #27

merged 1 commit into from
Dec 8, 2014

Conversation

soc
Copy link
Contributor

@soc soc commented Dec 6, 2014

No description provided.

@soc
Copy link
Contributor Author

soc commented Dec 8, 2014

Review by @adriaanm?

@adriaanm
Copy link
Contributor

adriaanm commented Dec 8, 2014

LGTM. Thanks, @soc!

adriaanm added a commit that referenced this pull request Dec 8, 2014
SI-7566 Remove use of String=>TermName implicit
@adriaanm adriaanm merged commit f0845fc into scala:master Dec 8, 2014
@soc
Copy link
Contributor Author

soc commented Dec 8, 2014

@adriaanm What's the appropriate way to release a new partest version now?

@adriaanm
Copy link
Contributor

adriaanm commented Dec 8, 2014

Create a release on github and let travis do its thing, then sign in to sonatype and promote the staged release to maven (last manual step that someone from the core team needs to do). I have this on my TODO for this week, but if you'd like to do it, I'll add you to the committers here (if that isn't the case yet) so you can do it.

@soc
Copy link
Contributor Author

soc commented Dec 10, 2014

Mhh, is https://github.com/soc/scala-partest/compare/scala:master...soc:topic/release-1.0.3?expand=1 going into the right direction? I set the version to 1.0.3, and created a tag called v1.0.3.

So what would be the next thing? Regarding that Sonatype thing, I only have an account for http://private-repo.typesafe.com, I guess that's something different?

@adriaanm
Copy link
Contributor

Thanks for taking this on -- sorry I wasn't clear! I was talking specifically about the "Release" page on github. The only required action from the module maintainer is pushing a tag (which the Release page lets you do from the web), and the automation does the rest (on Travis), all the way to staging a repo on sonatype. It doesn't promote that repo to maven central -- that's something only the core team can do.

So, I'll add you to the team that can push tags/merge PRs for partest, and you can cut the release!

@soc
Copy link
Contributor Author

soc commented Dec 10, 2014

Ok, thanks for the info. But I still have to change the version info
from 1.0.3-SNAPSHOT to 1.0.3 (and afterwards to 1.0.4-SNAPSHOT), right?

@adriaanm
Copy link
Contributor

No, the release automation derives the version from the tag. We do need to
bump to the next snapshot version after the release (for now), yes.

On Wed, Dec 10, 2014 at 9:12 AM, soc notifications@github.com wrote:

Ok, thanks for the info. But I still have to change the version info
from 1.0.3-SNAPSHOT to 1.0.3 (and afterwards to 1.0.4-SNAPSHOT), right?


Reply to this email directly or view it on GitHub
#27 (comment).

@soc
Copy link
Contributor Author

soc commented Dec 13, 2014

@adriaanm
Copy link
Contributor

Cool, thanks! Released to maven central. Could you submit a PR to scala/scala to update versions.properties?

@soc
Copy link
Contributor Author

soc commented Dec 15, 2014

Yes! :-) Both 2.11 and 2.12 or just 2.12?

@adriaanm
Copy link
Contributor

both, but I wouldn't change this in 2.11.5 at this point

lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
SI-7566 Remove use of String=>TermName implicit
lrytz pushed a commit to lrytz/scala-partest that referenced this pull request May 9, 2018
SI-7566 Remove use of String=>TermName implicit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants