This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Make ant a provided dependency #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ant is only needed to compile the Partest ant task. At runtime, the task is run by the Ant runner, so ant.jar and friends are already provided. In the scala build, this removes ant from the compile classpath of partest-extras, and from the runtime classpath of test.junit and the `test/partest` script. Nothing in partest other than the task depends on Ant, so there is no need to explicitly provide ant anywhere. Both `ant test.run` and `test/partest` should work fine with this change. The motivation for this is to prevent ant from appearing several time on the classpath, see [1]. [1]: https://groups.google.com/d/topic/scala-internals/EuMX5xu347o/discussion
|
To manually test that it works:
sbt 'set publishTo := Some(Resolver.file("file", new File(Path.userHome.absolutePath+"/.m2/repository")))' publish
sed -i 's/partest.version.number=1.0.1/partest.version.number=1.0.2-SNAPSHOT/g' versions.properties
test/partest # should start fine
ant test.run # should work too
ant test.junit # no more ant warning |
|
review @adriaanm |
|
LGTM! That was quick! |
|
I'll cut a new partest release after 2.11.3 is out. Since partest doesn't ship & it's not urgent, I'd like to fiddle with as few levers as possible in the homestretch before the next release. |
adriaanm
added a commit
that referenced
this pull request
Oct 7, 2014
Make ant a provided dependency
|
You guys are good. I mean, like, the good guys. |
|
My face goes 🌞 when I see good guys in action. |
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Make ant a provided dependency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ant is only needed to compile the Partest ant task. At runtime, the
task is run by the Ant runner, so ant.jar and friends are already
provided.
In the scala build, this removes ant from the compile classpath of
partest-extras, and from the runtime classpath of test.junit and the
test/partestscript. Nothing in partest other than the task dependson Ant, so there is no need to explicitly provide ant anywhere. Both
ant test.runandtest/partestshould work fine with this change.The motivation for this is to prevent ant from appearing several time on
the classpath, see [1].
[1] https://groups.google.com/d/topic/scala-internals/EuMX5xu347o/discussion