This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Properly quote regex replacement string in path canonicalization #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backslashes and dollars in regex replacement strings are interpreted
as back references. The canonicalization chokes on paths like:
/base/path/something/Foo$.js
(because of the `$`). Quoting the replacement string mitigates this.
|
LGTM |
gkossakowski
added a commit
that referenced
this pull request
Apr 18, 2014
Properly quote regex replacement string in path canonicalization
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Properly quote regex replacement string in path canonicalization
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Properly quote regex replacement string in path canonicalization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backslashes and dollars in regex replacement strings are interpreted as back references. The canonicalization chokes on paths like:
(because of the
$). Quoting the replacement string mitigates this.