Skip to content

Ignore www.oracle.com in htmlproofer #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

ashawley
Copy link
Member

@ashawley ashawley commented Oct 5, 2018

These links can't be helped. They just keep failing intermittently.

If these break, I'm pretty sure we'll hear about it, unlike a lot of the many other obscure links on the site. I believe it only affects 3 links on 3 pages:

- ./_site/documentation/your-first-lines-of-scala.html
  *  External link https://www.oracle.com/technetwork/java/index.html failed: 403 No error
- ./_site/download/2.12.7.html
  *  External link http://www.oracle.com/technetwork/java/javase/downloads/index.html failed: 403 No error
- ./_site/news/2.12.0/index.html
  *  External link https://www.oracle.com/technetwork/java/javase/downloads/index.html failed: 403 No error

Fixes #945.

Is unreliable, and gives a strange response, "403 No error".
Copy link
Member

@Philippus Philippus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, we've spent more than enough time on this :)

@SethTisue SethTisue merged commit d81c686 into scala:master Oct 5, 2018
@ashawley ashawley deleted the ignore-oracle branch October 9, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants