Skip to content

Fix scalac-profiling post #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 13, 2018
Merged

Conversation

ashawley
Copy link
Member

  • Various typos
  • Add link to Shapeless
  • Remove backticks from title
  • Remove parens on unnecessary parentheticals
  • Explain who Miles is.
  • scala/bug -> Scala issue tracker
  • Link to Bloop optimization PR

@ashawley ashawley changed the title Fix scalac profiling post Fix scalac-profiling post Jun 13, 2018
@SethTisue SethTisue requested a review from jvican June 13, 2018 17:32
Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections 👍

@jvican jvican merged commit 7b61ed7 into scala:master Jun 13, 2018
@ashawley ashawley deleted the fix-scalac-profiling-post branch June 13, 2018 19:29
@heathermiller
Copy link
Member

THANK YOU AARON!

Also, @jvican, have you ever heard of Grammarly? Daniel uses it all the time and it's helped his English writing a lot. It catches little grammar mistakes that only native speakers tend to be able to easily spot (as well as typos, of course). Highly recommended. I also use it myself to simplify and streamline my writing.

@jvican
Copy link
Member

jvican commented Jun 14, 2018

I'll give it a try, thanks for the recommendation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants